Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update dependency #108

Closed
wants to merge 3 commits into from

Conversation

da1suk8
Copy link
Member

@da1suk8 da1suk8 commented Oct 18, 2023

Description

Update following dependencies.

  • wasmvm from v1.1.1-0.11.4-rc1 to v1.1.1+0.11.5
  • ostracon to v1.1.2
  • finschia-sdk v0.48.0

When using +(build metadata) tag in wasmvm, the go command automatically changes the build metadata to the canonical version.
TestCheckLibwasmVersion was removed because the libwasmvm versions of wasmvm and wasmd cannot be compared.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is because the go command automatically converts the build metadata to the canonical version
and cannot compare the libwasmvm of wasmd and wasmvm
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #108 (587d59b) into main (1eb1bbd) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
+ Coverage   63.37%   63.41%   +0.04%     
==========================================
  Files          80       80              
  Lines        9954     9952       -2     
==========================================
+ Hits         6308     6311       +3     
+ Misses       3315     3311       -4     
+ Partials      331      330       -1     
Files Coverage Δ
x/wasm/module.go 35.15% <ø> (+0.54%) ⬆️

... and 1 file with indirect coverage changes

@da1suk8
Copy link
Member Author

da1suk8 commented Oct 18, 2023

Closed via: #109

@da1suk8 da1suk8 closed this Oct 18, 2023
@da1suk8 da1suk8 deleted the build/update_dependency branch October 18, 2023 23:49
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant